Skip to content

Conversation

@troysandal
Copy link

@troysandal troysandal commented Aug 22, 2025

I've gotten almost all the examples and tools working in XCode 16 using modern XCFrameworks and updated Pods. Remove TextMate support and fixed one Wax Unit Tests. The example apps I ported run on iOS18 but that's all I've tested. I ran the WAX_TEST in an example and got 8 errors, was able to fix one simple one.

Not Done

  • Tested Wax XCode Template
  • Updated Twitter example - X killed the API it's using, should either refactor or drop this example.
  • Lua 5.1.5 Update
  • Lua 5.x Support

wasn't checking for 64 bit arch and using doubles instead of floats.
not sure why junzhan added these to the .gitignore, they are definitely needed except the *.xcuserdata which was already covered
Did not checkin changes to wax.podspec to support this as it exposes more of lua/tolua++ and I'm not sure it's warranted (wasn't already done by junzhan).  Also replaced NSFW image.
Won't run because X (the company formerly known as Twitter) changed their API.
RIP old friend.
@CLAassistant
Copy link

CLAassistant commented Aug 22, 2025

CLA assistant check
All committers have signed the CLA.

To keep the wax codebase compilng for both Lua 5.x and Luau I added a shim file that redefines Lua 5.x macros to be compatible with Luau.  It's invasive and not my favorite solution but it seems least invasive of all fixes.

Updated all examples & tools.
We were trying to set the environment on the metatable of the userdata but didn't realize they all share the same metatable.  Now stored in a weak registry table.  And it works?
Gideros resets the Registry between runs of the player but we aren't notified when this happens and our ref goes bad.  If we could figure this out we can move back to refs which are much faster.
- lua_pointer() impl changed
- #1
Thes tests relied upon the return value from retainCount which is not defined and has changed since the tests were written.
init methods should have always return self
We should consider deleting these in the future.
@andy380743909
Copy link

Hi bro,

Have you ever tried to upgrade to Lua 5.3 or 5.4?

@troysandal
Copy link
Author

troysandal commented Nov 3, 2025

Have you ever tried to upgrade to Lua 5.3 or 5.4?

Out of scope for my project. Lua > 5.1 removed lua_setfenv()/lua_getfenv() and host of other things that would make that difficult. Roblox did similar things but I was able to hack around it. You're welcome to try it yourself if you'd like and I'd be happy to review your work.

@andy380743909
Copy link

Have you ever tried to upgrade to Lua 5.3 or 5.4?

Out of scope for my project. Lua > 5.1 removed lua_setfenv()/lua_getfenv() and host of other things that would make that difficult. Roblox did similar things but I was able to hack around it. You're welcome to try it yourself if you'd like and I'd be happy to review your work.

andy380743909#1

I have done some works about upgrading to Lua 5.3 5.4, but I'm not very sure whether it's correct. Please have a look, thanks very much!

@troysandal
Copy link
Author

I don't have time this week but can look at it next week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants