-
Notifications
You must be signed in to change notification settings - Fork 283
Support for XCode 16 #68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
wasn't checking for 64 bit arch and using doubles instead of floats.
not sure why junzhan added these to the .gitignore, they are definitely needed except the *.xcuserdata which was already covered
Did not checkin changes to wax.podspec to support this as it exposes more of lua/tolua++ and I'm not sure it's warranted (wasn't already done by junzhan). Also replaced NSFW image.
Won't run because X (the company formerly known as Twitter) changed their API.
RIP old friend.
To keep the wax codebase compilng for both Lua 5.x and Luau I added a shim file that redefines Lua 5.x macros to be compatible with Luau. It's invasive and not my favorite solution but it seems least invasive of all fixes. Updated all examples & tools.
We were trying to set the environment on the metatable of the userdata but didn't realize they all share the same metatable. Now stored in a weak registry table. And it works?
Gideros resets the Registry between runs of the player but we aren't notified when this happens and our ref goes bad. If we could figure this out we can move back to refs which are much faster.
- lua_pointer() impl changed - #1
Thes tests relied upon the return value from retainCount which is not defined and has changed since the tests were written.
init methods should have always return self
We should consider deleting these in the future.
|
Hi bro, Have you ever tried to upgrade to Lua 5.3 or 5.4? |
Out of scope for my project. Lua > 5.1 removed lua_setfenv()/lua_getfenv() and host of other things that would make that difficult. Roblox did similar things but I was able to hack around it. You're welcome to try it yourself if you'd like and I'd be happy to review your work. |
I have done some works about upgrading to Lua 5.3 5.4, but I'm not very sure whether it's correct. Please have a look, thanks very much! |
|
I don't have time this week but can look at it next week. |
I've gotten almost all the examples and tools working in XCode 16 using modern XCFrameworks and updated Pods. Remove TextMate support and fixed one Wax Unit Tests. The example apps I ported run on iOS18 but that's all I've tested. I ran the WAX_TEST in an example and got 8 errors, was able to fix one simple one.
Not Done